Add missing multi_ptr aliases for access::address_space::generic
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `[decorated_|raw_]generic_ptr` aliases definitions. These aliases were previously mentioned in the text (https://github.com/KhronosGroup/SYCL-Docs/blob/d314fbc9aead30704dd1f4d35db4b55b93bce7b0/adoc/chapters/architecture.adoc?plain=1#L1021), but their definitions were missing where their homologous are defined. Signed-off-by: Victor Perez <[email protected]>
|
|
|
Ignore the CI failure. I think this will be addressed by #597 |
I have no permissions in this repo yet. Can you please assign me the PR and some reviewers? It's quite a small one fixing a small gap in the doc |
|
Please add CTS tests. |
|
CTS tests PR: KhronosGroup/SYCL-CTS#935 |
victor-eds
added a commit
to intel/llvm
that referenced
this pull request
Sep 13, 2024
KhronosGroup/SYCL-Docs#598 adds these aliases to the spec. Prepare for spec change by adding them to the implementation beforehand. Extend tests so all `multi_ptr` aliases are checked. Signed-off-by: Victor Perez <[email protected]>
victor-eds
added a commit
to intel/llvm
that referenced
this pull request
Sep 13, 2024
KhronosGroup/SYCL-Docs#598 adds these aliases to the spec. Prepare for spec change by adding them to the implementation beforehand. Extend tests so all `multi_ptr` aliases are checked. Signed-off-by: Victor Perez <[email protected]>
|
Can we unlock this? We have CTS tests added and working implementation on |
gmlueck
approved these changes
Oct 24, 2024
TApplencourt
approved these changes
Oct 24, 2024
AerialMantis
approved these changes
Oct 24, 2024
|
CTS tests merged. Can we merge this too now? |
|
We need one more approver. Can someone be a hero? |
tomdeakin
approved these changes
Oct 30, 2024
|
WG approved to merge. |
gmlueck
pushed a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Nov 7, 2024
Cherry pick KhronosGroup#598 from main (cherry picked from commit 377f431)
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Add missing `multi_ptr` aliases for `access::address_space::generic` (cherry picked from commit 377f431)
victor-eds
added a commit
to intel/llvm
that referenced
this pull request
Nov 8, 2024
KhronosGroup/SYCL-Docs#598 adds these aliases to the spec. Prepare for spec change by adding them to the implementation beforehand. Extend tests so all `multi_ptr` aliases are checked. Signed-off-by: Victor Perez <[email protected]>
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 11, 2024
KhronosGroup/SYCL-Docs#598 adds these aliases to the spec. Prepare for spec change by adding them to the implementation beforehand. Extend tests so all `multi_ptr` aliases are checked. --------- Signed-off-by: Victor Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
[decorated_|raw_]generic_ptraliases definitions.These aliases were previously mentioned in the
text (
SYCL-Docs/adoc/chapters/architecture.adoc
Line 1021 in d314fbc