Fix contradiction with context constructors #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retarget to |
The context constructor overloads in the `context` synopsis did not match the description in the text of the specification. We decided that the overloads in the synopsis were what we intended, so change the text to match. We also discovered that two constructor overloads taking a `platform` argument were present in SYCL 1.2.1 and were inadvertently dropped from the SYCL 2020 specification. Add them back. Clarify the behavior of the constructors when the set of devices is empty. We decided that this should throw an exception, which is consistent with OpenCL's `clCreateContext`. Closes KhronosGroup#470 Closes KhronosGroup#474
gmlueck
force-pushed
the
gmlueck/context-constructors
branch
from
29cbcdc to
a4543c6
Compare
keryell
reviewed
Jan 9, 2025
| ---- | ||
| explicit context(const device& dev, async_handler asyncHandler = {}) | ||
| explicit context(const platform &plt, const property_list &propList = {}) |
There was a problem hiding this comment.
Have we changed the coding style about * and &? 🤔
There was a problem hiding this comment.
Oops, thanks for catching this. Fixed in 2887f9c.
TApplencourt
approved these changes
Jan 10, 2025
|
For my own benefit, this Intel internal tracker requests the CTS coverage for this PR: CMPLRLLVM-65051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context constructor overloads in the
contextsynopsis did not match the description in the text of the specification. We decided that the overloads in the synopsis were what we intended, so change the text to match.We also discovered that two constructor overloads taking a
platformargument were present in SYCL 1.2.1 and were inadvertently dropped from the SYCL 2020 specification. Add them back.Clarify the behavior of the constructors when the set of devices is empty. We decided that this should throw an exception, which is consistent with OpenCL's
clCreateContext.Closes #470
Closes #474