Fix error behavior for initialize_to_identity #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the specification said that a compiler must issue a diagnostic if the initialize_to_identity property was used without a known identity value. This requirement cannot be satisfied, because the presence of the initialize_to_identity value in a property_list cannot be proven until run-time. This change replaces the compile-time diagnostic with a run-time exception.
|
Good catch. I guess we can put this kind of stuff back when we have "compile-time properties". BTW, do we have a test on the CTS that we need to adjust? (aka compile time versus runtime error) |
TApplencourt
approved these changes
Oct 28, 2024
Agreed.
I think so. I'm not very good at reading the CTS tests, but it looks to me like we only test valid uses of |
gmlueck
approved these changes
Oct 28, 2024
AerialMantis
approved these changes
Nov 7, 2024
tomdeakin
approved these changes
Nov 7, 2024
|
WG approved to merge |
gmlueck
pushed a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Nov 7, 2024
Cherry pick KhronosGroup#651 from main (cherry picked from commit 8424248)
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Fix error behavior for initialize_to_identity (cherry picked from commit 8424248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the specification said that a compiler must issue a diagnostic if the
initialize_to_identityproperty was used without a known identity value. This requirement cannot be satisfied, because the presence of theinitialize_to_identityvalue in aproperty_listcannot be proven until run-time.This change replaces the compile-time diagnostic with a run-time exception.