QueryPoolComputeStatsTest: Check if query is supported in compute queue #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some drivers may not support queries in compute queue. This should turn some failures in dEQP-VK.query_pool.statistics_query.reset_after_copy.compute_shader_invocations.* to not supported.
|
|
temeraire-cx
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Sep 18, 2024
Turns out not even VK CTS was calling vkEnumeratePhysicalDeviceQueueFamilyPerformanceQueryCountersKHR() to check if queue supports query. So here adding a explicity check in our implementation of vkCreateQueryPool(). KhronosGroup/VK-GL-CTS#482 Cc: 24.2 <mesa-stable> Reviewed-by: Lionel Landwerlin <[email protected]> Signed-off-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30652>
temeraire-cx
pushed a commit
to chaotic-cx/mesa-mirror
that referenced
this pull request
Sep 23, 2024
Turns out not even VK CTS was calling vkEnumeratePhysicalDeviceQueueFamilyPerformanceQueryCountersKHR() to check if queue supports query. So here adding a explicity check in our implementation of vkCreateQueryPool(). KhronosGroup/VK-GL-CTS#482 Cc: 24.2 <mesa-stable> Reviewed-by: Lionel Landwerlin <[email protected]> Signed-off-by: José Roberto de Souza <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30652> (cherry picked from commit dec5a62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some drivers may not support queries in compute queue. This should turn some failures in
dEQP-VK.query_pool.statistics_query.reset_after_copy.compute_shader_invocations.* to not supported.