Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic barrier sum check #492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
#!amber
# Copyright 2024 The Amber Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


# The purpose of this test is to check the behavior of workgroup atomics in
# combination with barriers.
# This is known to cause issues on the mobile devices given the CTS failures
# for webgpu
# See: crbug.com/42241359

SHADER compute workgroup_shared_atomic_shader GLSL
#version 430

layout(local_size_x = 3, local_size_y = 1, local_size_z = 1) in;

layout(set = 0, binding = 0) buffer block1 {
uint ssbo_write[];
};

shared uint wg_shared;

void main() {
if( gl_LocalInvocationID.x == 0){
atomicExchange(wg_shared, 7);
}

barrier();
atomicAdd(wg_shared,1);
barrier();

if(gl_LocalInvocationID.x == 0) {
ssbo_write[0] = atomicExchange(wg_shared,0);
}
}
END

BUFFER buf_uint DATA_TYPE uint32 SIZE 16 FILL 123

PIPELINE compute pipeline
ATTACH workgroup_shared_atomic_shader
BIND BUFFER buf_uint AS storage DESCRIPTOR_SET 0 BINDING 0
END

RUN pipeline 1 1 1

EXPECT buf_uint IDX 0 EQ 10
34 changes: 34 additions & 0 deletions external/vulkancts/doc/vulkan-cts-withdrawal-2024-10.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
Dear Adopters,

This announcement provides notification that the Khronos Group Inc. intends
to withdraw Vulkan CTS 1.3.7.x releases.

These releases are being discontinued due to improved quality and coverage
provided by more recent releases. Once the releases are withdrawn it will not be
possible to make conformance submissions against these releases.

The Khronos Group recommends updating to Vulkan CTS 1.3.9.x and more recent releases
as early as possible.

This announcement covers the following tags as listed on
https://github.com/KhronosGroup/VK-GL-CTS/tags:
- vulkan-cts-1.3.7.0
- vulkan-cts-1.3.7.1
- vulkan-cts-1.3.7.2
- vulkan-cts-1.3.7.3

More information about Khronos Conformance and withdrawal policies can be found
in the Khronos Group Conformance Process document
(https://www.khronos.org/files/conformance_procedures.pdf) Attachment M.
Please contact the Vulkan CTS TSG chair (vk-gl-cts-wgchair at khronos.org) or
the Vulkan Working Group chair (vulkan-wgchair at khronos.org) if you have any questions.

Below are some key dates to acknowledge:

2024-10-02 Notice of intent to withdraw Vulkan CTS 1.3.7.x
distributed via email to adopters.

2025-03-28 The affected releases are withdrawn.

02 October 2024
Vulkan CTS Tech Lead
Original file line number Diff line number Diff line change
Expand Up @@ -5307,6 +5307,8 @@ tcu::TestCaseGroup *createBasicComputeShaderTests(tcu::TestContext &testCtx,
{
basicComputeTests->addChild(
cts_amber::createAmberTestCase(testCtx, "write_ssbo_array", "", "compute", "write_ssbo_array.amber"));
basicComputeTests->addChild(
cts_amber::createAmberTestCase(testCtx, "atomic_barrier_sum_small", "", "compute", "atomic_barrier_sum_small.amber"));
basicComputeTests->addChild(
cts_amber::createAmberTestCase(testCtx, "branch_past_barrier", "", "compute", "branch_past_barrier.amber"));
basicComputeTests->addChild(cts_amber::createAmberTestCase(
Expand Down
1 change: 1 addition & 0 deletions external/vulkancts/mustpass/main/vk-default/compute.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
dEQP-VK.compute.pipeline.basic.atomic_barrier_sum_small
dEQP-VK.compute.pipeline.basic.branch_past_barrier
dEQP-VK.compute.pipeline.basic.concurrent_compute
dEQP-VK.compute.pipeline.basic.copy_image_to_ssbo_large
Expand Down