Add GN build system #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Static library - Add overrides, not necessary yet but it will be when other parts of this repo wants to find Vulkan-Headers - Remove unused dependency on Vulkan-Headers from the settings library - Remove unreachable return flagged by clang
christophe-lunarg
force-pushed
the
add-gn
branch
from
7aede40
to
647235d
Compare
juan-lunarg
reviewed
Aug 14, 2023
Comment on lines
-561
to
-562
|
|
||
| return VK_ERROR_UNKNOWN; |
There was a problem hiding this comment.
I'm guessing this address a compiler warning?
There was a problem hiding this comment.
Is there CI for this new build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what I am doing here or what I am supose to do let alone where to find information on GN...