layer: Fix env variable trim modes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-lunarg
reviewed
Sep 4, 2023
Comment on lines
+55
to
+60
| std::string result = GetAndroidProperty(variable); | ||
| // Workaround for screenshot layer backward compatibility | ||
| if (result.empty() && std::string(variable) == "debug.vulkan.screenshot.frames") { | ||
| result = GetAndroidProperty("debug.vulkan.screenshot"); | ||
| } | ||
| return result; |
There was a problem hiding this comment.
Kinda awkward to have this workaround in this repository just for the screen shot layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A setting can be accessed using env variables using the following order:
VK_LUNARG_TEST_MY_SETTINGVK_TEST_MY_SETTINGVK_MY_SETTINGVK_MY_SETTINGmode was not working.