Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of comma operator in constant-expression context. #3411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test of comma operator in constant-expression context. #3411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/tests/conformance2/glsl3/00_test_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ array-in-complex-expression.html
--min-version 2.0.1 array-length-side-effects.html
attrib-location-length-limits.html
bool-type-cast-bug-uint-ivec-uvec.html
--min-version 2.0.1 comma-operator-not-constant-expression.html
compare-structs-containing-arrays.html
compound-assignment-type-combination.html
const-array-init.html
Expand Down
63 changes: 63 additions & 0 deletions sdk/tests/conformance2/glsl3/comma-operator-not-constant-expression.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<!--
Copyright (c) 2022 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->

<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Comma operator should be disallowed in constant-expression context</title>
<link rel="stylesheet" href="../../resources/js-test-style.css"/>
<link rel="stylesheet" href="../../resources/glsl-feature-tests.css"/>
<script src="../../js/js-test-pre.js"></script>
<script src="../../js/webgl-test-utils.js"></script>
<script src="../../js/glsl-conformance-test.js"></script>
</head>
<body>
<div id="description"></div>
<div id="console"></div>
<script id="vshader" type="x-shader/x-vertex">#version 300 es
in vec3 position;

void main() {
gl_Position = vec4(position, 1.0);
}
</script>
<script id="fshader" type="x-shader/x-fragment">#version 300 es
precision highp float;

uniform float time;
uniform vec2 resolution;
out vec4 out_color;

void main() {
int array[(2, 3)]; // <-- no error

vec2 position = -1.0 + 2.0 * gl_FragCoord.xy / resolution.xy;
float red = abs(sin(position.x * position.y + time / 5.0));
float green = abs(sin(position.x * position.y + time / 4.0));
float blue = abs(sin(position.x * position.y + time / 3.0));
out_color = vec4(red, green, blue, 1.0);
}
</script>
<script type="application/javascript">
"use strict";
description();
const wtu = WebGLTestUtils;
const tests = [
{
vShaderSource: wtu.getScript('vshader'),
fShaderSource: wtu.getScript('fshader'),
vShaderSuccess: true,
fShaderSuccess: false,
linkSuccess: false,
passMsg: 'Comma operator should be disallowed in constant-expression context, and fail to compile and link'
}
];

GLSLConformanceTester.runTests(tests, 2);
</script>
</body>
</html>