Add a test for the creation of RGBA16UI textures with UNPACK_PREMULTIPLY_ALPHA_WEBGL enabled for chromium issue 40929470
#3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enter the test for RGBA16UI textures when premultiply alpha is enabled
|
|
|
Requesting review from @kdashg and @kenrussell |
|
Thanks for your contribution and sorry for the long delay reviewing this. Have just built your Chromium pull request locally and verified that your new test catches the earlier bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGBA16UItextures, when created withUNPACK_PREMULTIPLY_ALPHA_WEBGLset totrueresult in the1282(GL_INVALID_OPERATION) error despite that being against standards and the same thing not happening on Firefox.The issue has been reported and a PR/CL has been requested:
Issue: https://issues.chromium.org/issues/40929470
PR/CL: https://chromium-review.googlesource.com/c/chromium/src/+/5525320
This PR is to add a test confirming that the issue's fix works and for future use.
There's also been an independent test made that this PR is based on:
https://github.com/RandomGamingDev/Chrome-UNPACK_PREMULTIPLY_ALPHA_WEBGL-Failure-Demo