Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conformance/rendering/blending for WebGL 1.0 #3671

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

lexaknyazev
Copy link
Member

No description provided.

Always use valid internal format enums to avoid
invalid texImage2D usage on WebGL 1.0.
@lexaknyazev lexaknyazev requested a review from kenrussell July 24, 2024 17:51
sdk/tests/conformance/rendering/blending.html Outdated Show resolved Hide resolved
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, either way the internalformat is passed to CreateValidFb.

@kdashg kdashg merged commit 0ee1bed into KhronosGroup:main Jul 25, 2024
2 checks passed
@lexaknyazev lexaknyazev deleted the fix-blending branch July 25, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants