Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ANGLE in Chrome test runner #3681

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Use ANGLE in Chrome test runner #3681

merged 1 commit into from
Aug 8, 2024

Conversation

daijh
Copy link
Contributor

@daijh daijh commented Aug 2, 2024

Chrome now relies solely on ANGLE, and removes the DesktopGL [1]. This commit update the Chrome flag to "--use-gl=angle" accordingly.

[1] https://issues.chromium.org/issues/40848940

Chrome now relies solely on ANGLE, and removes the DesktopGL [1].
This commit update the Chrome flag to "--use-gl=angle" accordingly.

[1] https://issues.chromium.org/issues/40848940

Signed-off-by: Jianhui Dai <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

@daijh
Copy link
Contributor Author

daijh commented Aug 2, 2024

This PR is ready for review.

Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. The --use-gl flag shouldn't be needed any more, but it seems fine to make this change.

@kenrussell kenrussell merged commit 7c70574 into KhronosGroup:main Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants