Use BigInt parameter in 16gb-wasm-memory tests #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kenrussell
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks for this contribution. In the description, is it more accurate to say "...to require BigInt parameters when the Memory type is i64"?
If so - looks good to me as long as we update the message when this is merged.
Could we also say "Associated with Chromium bug crbug.com/370792790" in the description when merging? Welcome to mention any other browser bugs too.
Thanks in advance.
The JS API for Memory was updated in WebAssembly/memory64#68 to require BigInt parameters when the Memory type is i64. Also see chromium-side failures (https://crbug.com/370792790).
|
Ack, I updated the commit message. Feel free to merge this any time. |
|
Discussed this in the WebGL WG meeting of 2024-10-03; as long as this is following the WebAssembly spec and has been tested in one implementation it seems fine to merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS API for Memory was updated in WebAssembly/memory64#68 to require BigInt parameters.