Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added QFN-16-1EP_4x4mm_P0.65mm_EP2.5x2.5mm #1870

Merged
merged 2 commits into from
Sep 28, 2019
Merged

Added QFN-16-1EP_4x4mm_P0.65mm_EP2.5x2.5mm #1870

merged 2 commits into from
Sep 28, 2019

Conversation

JeppeSRC
Copy link
Contributor

Added QFN-16-1EP_4x4mm_P0.65mm_EP2.5x2.5mm

Datasheet

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2019

CLA assistant check
All committers have signed the CLA.

@poeschlr
Copy link
Collaborator

I would assume the script pull request for this is pointhi/kicad-footprint-generator#430

Please read and sign our licence agreement.

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Sep 22, 2019
@JeppeSRC JeppeSRC mentioned this pull request Sep 22, 2019
6 tasks
@JeppeSRC
Copy link
Contributor Author

JeppeSRC commented Sep 22, 2019

Yes it is.

Is the CI supposed to complain about the paste and mask layers?

@poeschlr
Copy link
Collaborator

poeschlr commented Sep 22, 2019

our test scripts sadly do not work with thermal vias at this point in time. A fix for this is currently worked on KiCad/kicad-library-utils#288

Edit: to clarify the script should generate KLC compliant footprints (unless i have a bug in it) so travis can normally be ignored for scripted additions.

@poeschlr poeschlr self-assigned this Sep 22, 2019
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Sep 22, 2019
@poeschlr
Copy link
Collaborator

thanks

@poeschlr poeschlr merged commit b714305 into KiCad:master Sep 28, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Sep 30, 2019
pull bot pushed a commit to maximeborges/kicad-footprints that referenced this pull request Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants