added ST_VL53L0X and ST_VL53L1X

[valerionew]

Footprint for both VL53L0X and VL53L1X ST's Time of flight sensors.
Both sensors are pin compatible, and could use the same footprint. I'm not really sure on how to specify it so i left that part off the name. Should i make two separate identical footprints?

VL53L0X datasheet: https://www.st.com/resource/en/datasheet/vl53l0x.pdf
VL53L1X datasheet: https://www.st.com/resource/en/datasheet/vl53l1x.pdf

No symbol or 3D model so far. I'll make the symbol PR whenever this is approved, so that i can link it

EDIT:
Current versions:
ST_VL53L

ST_VL53L_HandSoldering

---

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the footprint(s) you are contributing
• An example screenshot image is very helpful
• If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
• Check the output of the Travis automated check scripts - fix any errors as required

[CLAassistant]

All committers have signed the CLA.

[valerionew]

First contribution here, anybody can help with TravisCI errors?

  Violating G1.7
    Library files must use Unix-style line endings (LF)
    Incorrect line ending
     - Library files must use Unix-style line endings (LF)

The file is generated directly from kicad, so i really can't understand what could be going wrong with the line ending. I'm on windows, but seems at least strange that i can't contribute if i'm a windows user.

  Violating F9.3
    3D model settings
    No 3D model provided

ST has not released any 3D model. I could make one but not now, and i don't know what would be the final name if i contribute it. What should i do?

[poeschlr]

You do not need to provide the 3d model it self. But you need to prepare the footprint for it. (So fill out the 3d settings as suggested by travis)

Regarding file endings. This should be taken care of by a proper git client. We have it setup such that such a client would automatically convert the line endings to unix stile. What client do you use? What is your git version?

[valerionew]

You do not need to provide the 3d model it self. But you need to prepare the footprint for it. (So fill out the 3d settings as suggested by travis)

Fixed, thanks! I thought that adding also the step file link would be better but travis gave an error on that. Now it passes.

Regarding file endings. This should be taken care of by a proper git client. We have it setup such that such a client would automatically convert the line endings to unix stile. What client do you use? What is your git version?

Actually i'm using github's drag and drop commit system. I'm not very confident with CLI git interface.

[valerionew]

@poeschlr can i push also the _HandSoldering version on this branch and on this PR? Or is it better to do a separate one?

[valerionew]

@poeschlr The last commit was done with git CLI on linux and is giving the same problem. I guess that is the file, not the client (Git 2.16.3)

[valerionew]

Now the _HandSoldering footprint is failing travis test because it uses the same 3D model as the other footprint.
To me is ok for merging, waiting the response of the mantainers

[Misca1234]

Now the _HandSoldering footprint is failing travis test because it uses the same 3D model as the other footprint.

That is ok, it is a known "problem" and it will be ignore.

[valerionew]

Fixed all the problems shared between this and my other PR (#805) for the regular footprint.

Travis errors shoud be ignored, beeing:

Violating F6.2
For surface-mount devices, footprint anchor is placed in the middle of the footprint (IPC-7351).
Footprint anchor is not located at center of footprint
- Footprint center calculated as (-0.04,0.0)mm

Pad 1 has an extra rectangle for marking. However pick and place center doesn't account for it. We shouldn't mess up the footprint for a travis tantrum.

Violating F9.3
3D model settings
3D model directory is different from footprint directory (found 'Opto-Devices.3dshapes', should be 'OptoDevice.3dshapes')
3D model name is different from footprint name (found 'ST_VL53L', expected 'ST_VL53L_HandSoldering'), but this might be intentional!

Definitely intentional.

Current proposed footprint:

I'm fixing also the handsoldering version, commit coming soon!

[valerionew]

Now also the _HandSoldering version footprint is committed. No relevant errors on travis, only the ones above. Waiting for mantainers to review

[valerionew]

@Misca1234 @poeschlr
Hi guys, i'm waiting for a review for this PR. When you have time can you look into it?

I've tested the _HandSoldering version and works OK (reflow soldering with stencil).

[valerionew]

@poeschlr the trick appears to be:

• make an empty commit
• git reset --hard "HEAD@{1}" (this also works for git resetting to another head, in Added Keystone 3002 #1183 i resetted to the head 5 before a rebase)
• force push
• make an empty commit again, to restart travis
• push

I don't know which one of these operations resolves the issue, but together they worked for this and the other PR

[valerionew]

@poeschlr can you please change the label to pending review? Thanks!

[poeschlr]

Looks quite good with one minor thing. Could you move the reference to the top side and the value to the bottom? (I kind of missed this in my previous reviews. Sorry about that.)

[poeschlr]

travis somehow behaves as if the diff range is given with .. instead of ... which is why it shows much more files as different. This is either a bug by the git version used or a dot is somehow lost somewhere between the echo command and git diff.

[poeschlr]

I somehow forgot to check this. looks good now, thanks

[valerionew]

@poeschlr why is this merged? The footprints were merged by #1621, this was left open for debugging the problems with travis

[poeschlr]

Damn today is not my day it seems. Luckily the footprints were identical so in essence i added an empty commit to the master branch (not good but not really a problem either)