Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add XP Power DC converters IA1205S and IH1205S and ITX1205S #1086

Merged
merged 60 commits into from
Feb 7, 2019
Merged

Add XP Power DC converters IA1205S and IH1205S and ITX1205S #1086

merged 60 commits into from
Feb 7, 2019

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Oct 22, 2018

https://www.xppower.com/pdfs/SF_IA.pdf
https://www.xppower.com/pdfs/SF_IH.pdf
https://www.xppower.com/pdfs/SF_ITX.pdf
https://www.xppower.com/pdfs/SF_ITQ.pdf
@stambaughw


  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Oct 22, 2018

itx.zip
FootprintsAnd3DModel.zip
The associated footprints

@ferdymercury ferdymercury changed the title Add XP Power DC converters IA1205S and IH1205S Add XP Power DC converters IA1205S and IH1205S and ITX1205S Oct 22, 2018
@antoniovazquezblanco antoniovazquezblanco added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Oct 23, 2018
@ferdymercury
Copy link
Contributor Author

image
image
image

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Oct 30, 2018

Started working on this again. Symbol IA reworked:
image

@ferdymercury
Copy link
Contributor Author

Here the ITX version. The IH is an alias of IA.
image

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Jan 26, 2019

Added the description for the IA series. Please review it before I continue with the other series. Thanks

@myfreescalewebpage
Copy link
Collaborator

@ferdymercury Will do.

@ferdymercury
Copy link
Contributor Author

added IH series

@ferdymercury
Copy link
Contributor Author

Added ITQ and ITX series. All symbols are now done. @myfreescalewebpage This is ready to be reviewed and merged.

@myfreescalewebpage myfreescalewebpage added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Ready for review Use this to mark pull requests that are updated but you could not review instantly labels Feb 5, 2019
@myfreescalewebpage
Copy link
Collaborator

@ferdymercury starting a new complete review from here. Sorry for the delay. However, I have a kicad error on opening, can you check this first ?

capture

Thanks,
Joel

@ferdymercury
Copy link
Contributor Author

Fixed, thanks for pointing out.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Feb 6, 2019

@ferdymercury here is the review:

IA0305D/IA4803D/IH0503D/IH0503DH:

  • Wrong pin numbers, not consistent with the footprints

ITQ2403SA-H:

  • Pin 8 (NC) should be moved to the border outline of the symbol, and should be renamed "NC" only

ITX0505S:

  • NC pins should be renamed "NC" only

ITX0505S-R:

  • NC pin should be renamed "NC" only

ITX0503SA

  • Pins 3 and 5 (NC) should be addedto the symbol.
  • NC pins should be renamed "NC" only

ITX0503SA-R:

  • Pin 8 (NC) should be moved to the border outline of the symbol, and should be renamed "NC" only
  • NC pins should be renamed "NC" only
  • Isolation barrier should be a single dash line

Cheers,
Joel

@ferdymercury
Copy link
Contributor Author

ferdymercury commented Feb 6, 2019

Changed. Thanks for the review.

Why should I add pins 3 and 5 in ITX0503SA?

They are marked as N.P. (no pin). This is different from N.C. (not connected)

@myfreescalewebpage
Copy link
Collaborator

@ferdymercury seems very nice now, no more comment to do on this PR.

Why should I add pins 3 and 5 in ITX0503SA?

Mistake during the review, you are right they are not populated.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage merged commit acc80ab into KiCad:master Feb 7, 2019
@antoniovazquezblanco antoniovazquezblanco modified the milestones: Backlog, 5.1.0 Feb 8, 2019
@ferdymercury ferdymercury deleted the patch-5 branch November 23, 2019 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants