Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add LT3015Q #1171

Merged
merged 4 commits into from
Dec 17, 2018
Merged

add LT3015Q #1171

merged 4 commits into from
Dec 17, 2018

Conversation

aewallin
Copy link
Contributor

LT3015Q adjustable negative low noise voltage regulator in TO-263-5 package.

datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/3015fb.pdf

Screenshot:
lt3015q


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@antoniovazquezblanco antoniovazquezblanco added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Nov 26, 2018
@antoniovazquezblanco antoniovazquezblanco added this to the Backlog milestone Nov 26, 2018
@myfreescalewebpage
Copy link
Collaborator

Hi @aewallin, thanks for contributing,

Looks great, maybe you can enlarge a little bit the symbol vertically between pins SHDN/VIN and ADJ/OUT. @antoniovazquezblanco @DanSGiesbrecht what do you think about that ? Else, ready to be merged.

Cheers,
Joel

@aewallin
Copy link
Contributor Author

We almost always use LT3015 (this one) together with LT1963 (PR #1169) - IMO best to make the symbols similar.
If the symbol shape is agreed on I can add these v-regulators in fixed-voltage output format and other footprints also.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Dec 12, 2018

@aewallin I agree we should treat both PR at the same time, I have the same remark about the size of the symbol for PR #1169.

Just adding below an example (LT3010) of what I mean by enlarging a little bit the symbol. This is to get a better consistency between symbols.

reg

This will also permit to fix KLC error S3.1 (travis output)

@myfreescalewebpage
Copy link
Collaborator

@aewallin can you fix the footprint filter to TO?263?5* ?

@evanshultz
Copy link
Collaborator

Footprint filters should not have pin count, so don't include the ?5 part. Furthermore, use asterisks instead of question makes wherever possible and that applies to all instances here. Note that I haven't looked at anything else but the last comment.

@myfreescalewebpage
Copy link
Collaborator

@evanshultz ok. @aewallin so keep the footprint like that for that PR.

@aewallin
Copy link
Contributor Author

fp-filter changed.
box enlarged.
library seems inconsistent on negative voltage regulators: to have Vin/Vout at bottom and GND at top, or like positive regulators Vin/Vout at top and GND at bottom. now using latter approach.
lt3015q

@myfreescalewebpage
Copy link
Collaborator

library seems inconsistent on negative voltage regulators: to have Vin/Vout at bottom and GND at top, or like positive regulators Vin/Vout at top and GND at bottom. now using latter approach.

Not sure it's very convenient to draw the schematic now, or maybe you can provide a screenshot. You're right the library is not consistent, I think I prefer the opposite, with GND pin at the top. Reference at the bottom left corner, name at the bottom right corner. This will make a KLC error, @antoniovazquezblanco @evanshultz what is your opinion ?

Joel

@aewallin
Copy link
Contributor Author

maybe you can provide a screenshot.

The two styles I was thinking about are below. Maybe it is best to have symbols KLC-compliant with GND down, and the user can flip with X/Y as appropriate for the schematic.

GND-down style on +v and -v:
dual-polarity-regulated-power-supply-1326579994

GND-up on -v, with a symmetryc drawing for a bipolar supply:
dual voltage

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Dec 13, 2018

@aewallin agreed with you I have forgotten X flip possibility and just made a try. Your proposition sounds good and it respects the KLC so that's also very nice !

@aewallin also just checked other symbols, according to me ADJ should be Input, not Passive.

@aewallin
Copy link
Contributor Author

@myfreescalewebpage Looking at examples from the current regulator_linear library it looks like some ADJ/SENSE/FB pins are marked Passive, and some are marked Input.

Any opinion on this from a Librarian - I'll change the ADJ pin type here and in #1169, if there is consensus.

@myfreescalewebpage
Copy link
Collaborator

Any librarian about ADJ pin type question ? Thanks.

@antoniovazquezblanco
Copy link
Collaborator

@KiCad/librarians question above, please :)

@Misca1234
Copy link
Collaborator

Even if older merges is different I would argue to follow the data sheet,
according to page 14,
SHDN should be input
SENSE should be input

@DanSGiesbrecht
Copy link
Collaborator

I think that either passive or input is suitable for ADJ. I have seen it argued that it should be passive because you could feed it with a resistor-divider, but this wouldn't generate an ERC warning if the pin was an input. This could be suggested to be formalized in the KLC.

@Misca1234
Copy link
Collaborator

yes, the ERC .....

@aewallin
Copy link
Contributor Author

after changes:
lt3015q

@poeschlr
Copy link
Collaborator

Regarding pin types: we are working on setting up an algorithm for determening which type to use. See KiCad/kicad-website#342

@Misca1234
Copy link
Collaborator

I am happy with this little gem, any objections ?

@poeschlr
Copy link
Collaborator

Not from my side. As there are already so many reviews i am going to assume this is ok and simply merge. Thanks @aewallin for your great work here.

@poeschlr poeschlr merged commit 6c866a7 into KiCad:master Dec 17, 2018
@DanSGiesbrecht DanSGiesbrecht removed the Pending reviewer A pull request waiting for a reviewer label Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants