Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Relay: Add Panasonic ADW11 series #1915

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Relay: Add Panasonic ADW11 series #1915

merged 3 commits into from
Mar 12, 2020

Conversation

antoniovazquezblanco
Copy link
Collaborator

@antoniovazquezblanco antoniovazquezblanco commented Jun 11, 2019 •
edited
Loading

Datasheet: https://www.panasonic-electric-works.com/pew/es/downloads/ds_dw_hl_en.pdf

SYM PR: #1915
FP PR: KiCad/kicad-footprints#1638
3D PR: KiCad/kicad-packages3D#572
3D SOURCE PR: easyw/kicad-3d-models-in-freecad#289

imagen

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging labels Jun 11, 2019
This was referenced Jun 19, 2019
Merged
Merged
Merged
@evanshultz evanshultz self-assigned this Jun 20, 2019
@evanshultz
Copy link
Collaborator

  1. Can it just be ADW11? The 'W' suffix is only on packaging and the datasheet clearly mentions 'ADW1'.
  2. Please note a single coil in the description to differentiate if ADW12 is added later.
  3. Can you show polarity of the coil?
  4. I count an excessive number of rectangles and polylines in the symbol. Only 5 and 10, respectively, should be needed. Can you simplify it?

@antoniovazquezblanco
Copy link
Collaborator Author

Used a style more conforming to what currently exists in the lib:
imagen

@evanshultz
Copy link
Collaborator

Great! Just need the footprint.

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Jun 25, 2019
@antoniovazquezblanco
Copy link
Collaborator Author

Depends on KiCad/kicad-website#418

@antoniovazquezblanco antoniovazquezblanco added the Pending KLC issue This depends on a open KLC issue label Jul 22, 2019
@antoniovazquezblanco
Copy link
Collaborator Author

Updated FP. FP merged.

@antoniovazquezblanco antoniovazquezblanco removed Pending KLC issue This depends on a open KLC issue Pending footprint Pending footprint acceptance before merging labels Mar 12, 2020
@evanshultz
Copy link
Collaborator

Thanks!

@evanshultz evanshultz merged commit 5b1918d into KiCad:master Mar 12, 2020
@antoniovazquezblanco
Copy link
Collaborator Author

Thank you!

@antoniovazquezblanco antoniovazquezblanco deleted the dev/relay branch March 16, 2020 08:00
jamesrlucas pushed a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
@antoniovazquezblanco @jamesrlucas
Relay: Add Panasonic ADW11 series (KiCad#1915)
04ff3d0 
* Relay: Add Panasonic ADW11 series

* Relay: Simplify panasonic AD11 symbol

* Update footprint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@evanshultz evanshultz

Labels
Addition Adds new symbols to library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoniovazquezblanco @evanshultz