Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

3W and 5W AC/DC converters from Hi-Link. #845

Closed
wants to merge 1 commit into from

Conversation

Sthing
Copy link
Contributor

@Sthing Sthing commented Aug 23, 2018

Footprints in KiCad/kicad-footprints#860

3W modules

HLK-PM03, HLK-PM01, HLK-PM12

http://www.hlktech.net/product_detail.php?ProId=60

image

5W modules

HLK-5M03, HLK-5M05, HLK-5M12

http://www.hlktech.net/product_detail.php?ProId=54

image


  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

HLK-PM03, HLK-PM01, HLK-PM12
HLK-5M03, HLK-5M05, HLK-5M12
@antoniovazquezblanco antoniovazquezblanco added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Oct 5, 2018
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Dec 13, 2018

Hi @Sthing, thanks for contributing,

A few comments I have during my review:

  • I have not found datasheets in PDF format, not sure they are available on the manufacturer website, but it's better if you have a link ?
  • HLK-PM12 datasheet is in PDF format but it is better if you redirect to the manufacturer website because link can be break at any time by this site
  • You should cross Vout pins to get positive pin on the top right and negative pin at the bottom right
  • You are violating KLC S3.6 and S5.2 that are easy to solve, please check at the travis output.
  • For consistency with the other devices in the library, remove current in the description, for example look at "HS-40003" : "3.3V, 3W, AC-DC module power supply, Hahn"
  • For consistency with the other devices in the library, remove current in the keywords, for example look at "HS-40003" : "3.3V 3W AC-DC module power supply"
  • For consistency with the other devices in the library, can you also change the layout, here is an example. If we have no detailed datasheet, I would also suggest to put the same names to the pins ("AC(L)", "AC(N)", "Vout+" and "Vout-").

49945213-a47a1000-feec-11e8-9bdb-bb077f4c54b7

(screenshot from #1092 (comment))

Also, we are waiting for your response about the footprint at KiCad/kicad-footprints#860

Cheers,
Joel

@evanshultz
Copy link
Collaborator

  • Change pin name offset to 20mil.
  • Pins 1 and 2 may be correctly named just AC as it may not matter which is connected to Line and which to Neutral. It would depend on the circuit design inside the module.
  • At Add isolation lines to ACDC converter symbols  #429 we decided to use a single dashed line to separate Primary and Secondary pins in this type of symbol.
  • If some of the PNs are PMxx and some are 5Mxx the footprint naming should indicate that, so please consider that in the footprint name and, once the footprint is merged, update this PR to match.

@myfreescalewebpage
Copy link
Collaborator

@Sthing up ?

@myfreescalewebpage myfreescalewebpage self-assigned this Dec 23, 2018
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Dec 23, 2018
@Encrypt
Copy link

Encrypt commented Jan 19, 2019

Hello everyone!

I've just noticed that these symbols were added to the library in #1147
I guess you can close this issue :)

@myfreescalewebpage
Copy link
Collaborator

Hello @Encrypt thanks for pointing this to our attention! I was wondering also if original author as stop working on this subject. I label with Abandoned and Duplicated tags and close the PR now.
Also closing the footprint PR KiCad/kicad-footprints#860 for the same reason.
Joel

@myfreescalewebpage myfreescalewebpage added Duplicate Already reported Abandoned Original author has stopped working on the PR labels Jan 20, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library Duplicate Already reported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants