fix: Fix about modal version for cloud installations (mattermost#25389)

Kimbohlovette · Nov 13, 2023 · bdb363b · bdb363b
1 parent 9cf84fb
commit bdb363b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/webapp/channels/src/components/about_build_modal/about_build_modal.test.tsx b/webapp/channels/src/components/about_build_modal/about_build_modal.test.tsx
@@ -106,7 +106,7 @@ describe('components/AboutBuildModal', () => {
 
         expect(screen.getByText('Mattermost Cloud')).toBeInTheDocument();
         expect(screen.getByText('High trust messaging for the enterprise')).toBeInTheDocument();
-
+        expect(screen.getByTestId('aboutModalVersion')).toHaveTextContent('Mattermost Version: 3.6.0');
         expect(screen.getByText('0123456789abcdef', {exact: false})).toBeInTheDocument();
         expect(screen.getByRole('link', {name: 'server'})).toHaveAttribute('href', 'https://github.com/mattermost/mattermost-server/blob/master/NOTICE.txt');
         expect(screen.getByRole('link', {name: 'desktop'})).toHaveAttribute('href', 'https://github.com/mattermost/desktop/blob/master/NOTICE.txt');

diff --git a/...nels/src/components/about_build_modal/about_build_modal_cloud/about_build_modal_cloud.tsx b/...nels/src/components/about_build_modal/about_build_modal_cloud/about_build_modal_cloud.tsx
@@ -57,11 +57,6 @@ export default function AboutBuildModalCloud(props: Props) {
         </div>
     );
 
-    let mmversion = config.BuildNumber;
-    if (!isNaN(config.BuildNumber)) {
-        mmversion = 'ci';
-    }
-
     return (
         <Modal
             dialogClassName={classNames('a11y__modal', 'about-modal', 'cloud')}
@@ -94,12 +89,12 @@ export default function AboutBuildModalCloud(props: Props) {
                         </h3>
                         <p className='subtitle'>{subTitle}</p>
                         <div className='description'>
-                            <div>
+                            <div data-testid='aboutModalVersion'>
                                 <FormattedMessage
                                     id='about.version'
                                     defaultMessage='Mattermost Version:'
                                 />
-                                <span id='versionString'>{'\u00a0' + mmversion}</span>
+                                <span id='versionString'>{'\u00a0' + config.Version}</span>
                             </div>
                         </div>
                         {licensee}