Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] mail_layout_preview: Migration to 18.0 #3

Closed
wants to merge 20 commits into from

Conversation

Kimkhoi3010
Copy link
Owner

No description provided.

Comment on lines 1 to 6
The development and migration of this module from 15.0 to 16.0 has been
financially supported by:

- Camptocamp


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The development and migration of this module from 15.0 to 16.0 has been
financially supported by:
- Camptocamp

remove it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove traces from the past?

The development and migration of this module from 15.0 to 16.0 and from 17.0 to 18.0 has been
financially supported by:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought when he append message 17.0 to 18.0, we don't need old message above

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-mail_layout_preview branch 2 times, most recently from c250a76 to 792e231 Compare October 8, 2024 11:05
@nilshamerlinck
Copy link

if https://github.com/OCA/social/pull/1371 works, then you can take the occasion to approve it as well

@nilshamerlinck
Copy link

@chaule97 is this module still useful?

@chaule97
Copy link

@chaule97 is this module still useful?

yes, sorry I forgot about it

@nilshamerlinck
Copy link

why is it still useful?

@chaule97
Copy link

why is it still useful?

I think someone might want to preview the template in full screen.
image

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-mail_layout_preview branch from ae5ba18 to b50448d Compare October 15, 2024 02:53
@Kimkhoi3010 Kimkhoi3010 requested a review from chaule97 October 16, 2024 07:54
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-mail_layout_preview branch from b50448d to 399e6f1 Compare October 16, 2024 07:57
@Kimkhoi3010
Copy link
Owner Author

I created a new PR OCA#1472 to OCA/social.
(This PR was closed auto after rebased)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants