-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Doesn't recognize neoforge.mods.toml
if neoforge
dependency is omitted
#130
Comments
(mc-publish does not recognize neoforge by default Kir-Antipov/mc-publish#130) Remember to undo: "./gradlew chiseledBuildNeoForge" in publlish.yml
* Began migration to stonecutter architectury Forge/NeoForge support still unfinished. Icon is not displaying in ModMenu. Missing publishing script. * Fix stonecutter comments * Forge & NeoForge support Implemented config screens for Forge & NeoForge. Fixed icon not showing in config screen. * Forgot to change logo path * Fix license * Fix readme (reverted) * Initial implementation of publishing workflow Fixed comments messing up chiseledBuild. * Fixed mc version numbers in publishing workflow * Edited file globs * 1.21.3 support & publish workflow finishing touches * More glob changes * Forgot to set project id for modrinth & curseforge * Bumped mod version Also shrunk publish.yml to prepare for testing * Trying to add loader info to see if it fixes error * Declared dependencies (mc-publish does not recognize neoforge by default Kir-Antipov/mc-publish#130) Remember to undo: "./gradlew chiseledBuildNeoForge" in publlish.yml * Tried to get cloth_config to show as dependency when uploading Also expanded action testing to fabric and forge. * Fix mistakes with dependencies * Returned publish.yml back to normal (Yayyy, publishing now works properly) * Improved publish action * Oops * Update publish.yml
Hello there, is there any progress on this? It would be nice to have dependency recognized without the need to specify them in the CI |
Hi! Yup, there definitely is! I believe I've fixed/implemented almost everything related to the issues in this repo in my local tree (except for Hangar and stuff like that). However, I'm currently in the midst of migrating |
@Kir-Antipov Anything that can be helped with in the mentioned PR? |
Description
Currently,
mc-publish
doesn't recognizeneoforge.mods.toml
as a valid NeoForge metadata file if it omits theneoforge
dependency block (e.g., like it's done in Sodium):This check was only relevant before NeoForge diverged from using the same
mods.toml
as legacy Forge. Nowadays, the mere existence ofneoforge.mods.toml
is a sufficient indicator that the mod supports NeoForge.Expected Behavior
mc-publish
should be able to readneoforge.mods.toml
even if it doesn't explicitly specify theneoforge
dependency block.Actual Behavior
mc-publish
fails to readneoforge.mods.toml
if theneoforge
dependency block is omitted, effectively disabling automatic property resolution.Version
v3
Environment
GitHub Actions
Configuration
No response
Logs
No response
Other Information
No response
The text was updated successfully, but these errors were encountered: