Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Doesn't recognize neoforge.mods.toml if neoforge dependency is omitted #130

Open
Kir-Antipov opened this issue Oct 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Kir-Antipov
Copy link
Owner

Kir-Antipov commented Oct 19, 2024

Description

Currently, mc-publish doesn't recognize neoforge.mods.toml as a valid NeoForge metadata file if it omits the neoforge dependency block (e.g., like it's done in Sodium):

[[dependencies.example-mod]]
    modId="neoforge"
    versionRange="[34,)"
    ordering="NONE"
    side="BOTH"

This check was only relevant before NeoForge diverged from using the same mods.toml as legacy Forge. Nowadays, the mere existence of neoforge.mods.toml is a sufficient indicator that the mod supports NeoForge.

Expected Behavior

mc-publish should be able to read neoforge.mods.toml even if it doesn't explicitly specify the neoforge dependency block.

Actual Behavior

mc-publish fails to read neoforge.mods.toml if the neoforge dependency block is omitted, effectively disabling automatic property resolution.

Version

v3

Environment

GitHub Actions

Configuration

No response

Logs

No response

Other Information

No response

@Kir-Antipov Kir-Antipov added the bug Something isn't working label Oct 19, 2024
HaXrDEV added a commit to HaXrDEV/Branded-Logs that referenced this issue Oct 27, 2024
(mc-publish does not recognize neoforge by default Kir-Antipov/mc-publish#130)

Remember to undo:
"./gradlew chiseledBuildNeoForge" in publlish.yml
HaXrDEV added a commit to HaXrDEV/Branded-Logs that referenced this issue Oct 28, 2024
* Began migration to stonecutter architectury

Forge/NeoForge support still unfinished.

Icon is not displaying in ModMenu.

Missing publishing script.

* Fix stonecutter comments

* Forge & NeoForge support

Implemented config screens for Forge & NeoForge.

Fixed icon not showing in config screen.

* Forgot to change logo path

* Fix license

* Fix readme (reverted)

* Initial implementation of publishing workflow

Fixed comments messing up chiseledBuild.

* Fixed mc version numbers in publishing workflow

* Edited file globs

* 1.21.3 support & publish workflow finishing touches

* More glob changes

* Forgot to set project id for modrinth & curseforge

* Bumped mod version

Also shrunk publish.yml to prepare for testing

* Trying to add loader info to see if it fixes error

* Declared dependencies

(mc-publish does not recognize neoforge by default Kir-Antipov/mc-publish#130)

Remember to undo:
"./gradlew chiseledBuildNeoForge" in publlish.yml

* Tried to get cloth_config to show as dependency when uploading

Also expanded action testing to fabric and forge.

* Fix mistakes with dependencies

* Returned publish.yml back to normal

(Yayyy, publishing now works properly)

* Improved publish action

* Oops

* Update publish.yml
@Faboslav
Copy link

Faboslav commented Jan 8, 2025

Hello there, is there any progress on this? It would be nice to have dependency recognized without the need to specify them in the CI

@Kir-Antipov
Copy link
Owner Author

Hi! Yup, there definitely is! I believe I've fixed/implemented almost everything related to the issues in this repo in my local tree (except for Hangar and stuff like that). However, I'm currently in the midst of migrating mc-publish to a new runtime (and containerizing it along the way), because I'm quite frustrated with how GitHub handles Node.js actions; and I've been also dealing with some IRL stuff, so yeah, I definitely took my sweet time with this update xD I hope to finally release v4 before Mojang drops 1.22 on us :)

@Faboslav
Copy link

@Kir-Antipov Anything that can be helped with in the mentioned PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants