-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to NodeJS 20 #124
Draft
shartte
wants to merge
2
commits into
Kir-Antipov:master
Choose a base branch
from
shartte:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update to NodeJS 20 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After further investigation:
|
Hi! Thanks a lot for your determination to help :) Just a few things I wanted to mention:
Now, to the matters of the PR itself.
|
With that bug in stream-zip-fs and the package unmaintained, there is not
really a path forward.
Regarding in memory tests: you are making your tests more complex that way
and don't discover bugs like this one in stream-zip-fs 😀
Kir_Antipov ***@***.***> schrieb am So., 30. Juni 2024, 15:18:
… Hi! Thanks a lot for your determination to help :)
Just a few things I wanted to mention:
1. Please, do not include auto-generated files in the PR. I.e., *.g.ts,
dist/*, and action.yml should never be committed. I almost had a heart
attack when I saw "-564" on this PR :D I thought this was obvious, but I
guess I need to explicitly state this in the contributing guidelines.
2. Please try to keep the commit history of the PR clean from
meaningless commits like "Trigger CI." This particular one is going to be
squashed anyway, but it’s a good practice to maintain in general.
------------------------------
Now, to the matters of the PR itself.
1. I'm not a big fan of mock-fs either, as it behaves pretty strangely
even now: if a test that utilizes it fails, it *may* lead to random
failures in other tests. So, I would be happy to replace it with something
more mature and up-to-date. What are the problems with the suggested
alternatives? I assume they don't implement async operations?
2. I didn't want to implement tests using temp files for two reasons:
personally, I dislike unnecessary file operations when everything can be
stored in memory; and arguably more importantly, this approach usually ends
up being pretty messy and intertwined, but I haven't seen your solution, so
I cannot speak on its behalf yet :)
3. Surprisingly, there aren't many lightweight packages for Node that
deal with zip archives, so the choice was pretty limited. I didn't want to
reinvent yet another wheel for this project at the time because I was kinda
burnt out, so I just stuck with node-stream-zip as it did an okay job.
—
Reply to this email directly, view it on GitHub
<#124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJT6V4SBTWFMLGSRA6SSJLZKAARDAVCNFSM6AAAAABJZW6LFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGU3DAOJVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin :-)
Fixes #108
Tests are broken. Working on that.
mock-fs seems unmaintained and affected by changes in NodeJS 20. Relevant issue: tschaub/mock-fs#377