Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve error in internship #57

Merged

Conversation

yuvraj-rathod-1202
Copy link
Contributor

#56
i add feature to show previously added intern detail

Brief description of what is fixed or changed

Other comments

@yuvraj-rathod-1202
Copy link
Contributor Author

Please review this

Copy link
Owner

@Kishan-Ved Kishan-Ved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts. Then, we can merge this.

@yuvraj-rathod-1202
Copy link
Contributor Author

conflict is resolved now it is able to merge, please consider this

@Kishan-Ved
Copy link
Owner

BUG:

  1. add some internship data
  2. Click on Add this
  3. Uncheck the internships section
  4. Add some other internship data
  5. Click on add this

The preview shows the previously added internship also, ideally, it should not be there
The latex code also contains the previously added internship details
We can't delete the previously added internship (there is no delete button for it in the menu). Ideally, it should not be there because the user had unchecked the box, so all data added previously should be erased.

@yuvraj-rathod-1202
Copy link
Contributor Author

I resolve the bug, please check this and provide your valuable feedback

@Kishan-Ved
Copy link
Owner

Great! There is another small bug: the update button isn't working as expected

Bug:

  1. Add some internship data
  2. Click on add this
  3. Click on edit
  4. Change data
  5. Click on update

See the menu, it shows this:
image

@yuvraj-rathod-1202
Copy link
Contributor Author

now it is fixed, please check this

Copy link
Owner

@Kishan-Ved Kishan-Ved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks @yuvraj-rathod-1202 for this PR!

@Kishan-Ved Kishan-Ved merged commit a351aa5 into Kishan-Ved:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants