Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Version + Improvements #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Final Version + Improvements #1

wants to merge 5 commits into from

Conversation

azimafroozeh
Copy link

No description provided.

@azimafroozeh
Copy link
Author

Add the final version of Lacuna2.
Use the unminify library (npm i unminify) to save uncompressed javaScripts instead of saving downloaded JavaScript directly. This solves the Invalid range error given by getOuterRangeArray.
The HTML file is not the same before and after using the cheerio library. This pull request tries to replace some tags with the ones cheerio will generate, found in our workload(WebPages). Using another html editor library can be also an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azimafroozeh