Merge pull request #105 from ConvertKit/test-php-8.3

Run tests against PHP 8.3
Kit · Dec 11, 2023 · 3045b61 · 3045b61
2 parents a89cdd5 + 762b749
commit 3045b61
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 18 deletions.
diff --git a/.github/workflows/coding-standards.yml b/.github/workflows/coding-standards.yml
@@ -36,7 +36,7 @@ jobs:
     strategy:
       matrix:
         wp-versions: [ 'latest' ] #[ '6.1.1', 'latest' ]
-        php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] #[ '7.3', '7.4', '8.0', '8.1' ]
+        php-versions: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ] #[ '7.3', '7.4', '8.0', '8.1' ]
 
     # Steps to install, configure and run tests
     steps:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -45,7 +45,7 @@ jobs:
       fail-fast: false
       matrix:
         wp-versions: [ 'latest' ] #[ '6.1.1', 'latest' ]
-        php-versions: [ '7.4', '8.0', '8.1', '8.2' ] #[ '7.4', '8.0', '8.1' ]
+        php-versions: [ '7.4', '8.0', '8.1', '8.2', '8.3' ] #[ '7.4', '8.0', '8.1' ]
 
         # Folder names within the 'tests' folder to run tests in parallel.
         test-groups: [
@@ -110,9 +110,9 @@ jobs:
         run: wp-cli plugin install ${{ secrets.CONVERTKIT_PAID_PLUGIN_URLS }}
 
       # WP_DEBUG = true is required so all PHP errors are output and caught by tests (E_ALL).
-      # WP_DEBUG = false for PHP 8.2, otherwise E_DEPRECATED is output due to Gravity Forms.
+      # WP_DEBUG = false for PHP 8.2 and 8.3, otherwise E_DEPRECATED is output due to Gravity Forms.
       - name: Enable WP_DEBUG
-        if: ${{ matrix.php-versions != '8.2' }}
+        if: ${{ matrix.php-versions != '8.2' && matrix.php-versions != '8.3' }}
         working-directory: ${{ env.ROOT_DIR }}
         run: |
           wp-cli config set WP_DEBUG true --raw

diff --git a/tests/nginx/php-7.3.conf b/tests/nginx/php-7.3.conf
diff --git a/tests/nginx/php-7.2.conf → tests/nginx/php-8.3.conf b/tests/nginx/php-7.2.conf → tests/nginx/php-8.3.conf
@@ -8,6 +8,6 @@ server {
     }
     location ~ \.php$ {
         include snippets/fastcgi-php.conf;
-        fastcgi_pass unix:/var/run/php/php7.2-fpm.sock;
+        fastcgi_pass unix:/var/run/php/php8.3-fpm.sock;
     }
 }