Add Notice Recommending Official Add-On #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As requested here:
Once the official add-on is installed and activated, it perform its own check to determine whether this Plugin is active, deactivating it if so. They retain our settings.
Testing
NoticesCest:testPersistentNoticeDisplays
: Test that the persistent notice displays when this Plugin is active.NoticesCest:testPersistentNoticeNotDisplayedWhenOfficialAddonActive
: Test that the persistent notice does not display when the official add-on is activate.Checklist