Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Secure Log in WordPress Libraries #108

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Use Secure Log in WordPress Libraries #108

merged 2 commits into from
Mar 8, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Uses a more secure log file method, as added in our WordPress Libraries.

Testing

Existing tests pass.

Checklist

@n7studios n7studios added the bug label Mar 7, 2024
@n7studios n7studios self-assigned this Mar 7, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team March 7, 2024 17:28
@n7studios n7studios marked this pull request as ready for review March 7, 2024 17:28
noelherrick
noelherrick approved these changes Mar 8, 2024
View reviewed changes
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said with the other one, as soon as we update the api library version number, this looks good to go.

@n7studios n7studios merged commit 229185d into main Mar 8, 2024
27 checks passed
@n7studios n7studios deleted the move-log-file-location branch April 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenessawhite jenessawhite jenessawhite approved these changes

@noelherrick noelherrick noelherrick approved these changes

Assignees

@n7studios n7studios

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n7studios @noelherrick @jenessawhite