This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add penalties for team-kill assists and team-flash-assists (BUG #211) #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate your time and I merge your changes, but we drop the rework of the plugin shortly :( But I highly appreciate your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, the added checks in RankEvents.cs would fix the bug that getting assists on killed teammates (or getting a flash-assist on your teammate) would give a penalty instead of a reward. In case of FFA this check is of course not applied.
However, how do the language files work? I have only added it to the english file (since I do not speak the other languages). Do I need to add it to the other files? - if yes, should I use google translate for this?
This PR references bug #211