fix: upon entering sketch mode, axis do not rotate. #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
approved these changes
Dec 4, 2024
jessfraz
pushed a commit
that referenced
this pull request
Dec 5, 2024
* fix: upon entering sketch mode, axis do not rotate. * fix: camera settings has the up vector to set, this should now work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The axis for sketch mode can have a rotation applied when entering the sketch mode which is wrong.
How to recreate the bug
Do not look perpendicular to your sketch plane then enter the sketch mode on that plane. Some rotation will be applied
Fix
Set the orientation from the cam settings directly to the camera instead of recomputing a new up vector.
Turns out we can use the up vector from the camera settings that is returned instead of hard coding it to
<0,1,0>.Video description
2024-11-25.14-06-30.mp4