-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow standard planes to appear in the artifact graph #4594
base: main
Are you sure you want to change the base?
Conversation
jtran
commented
Nov 27, 2024
- Part of Default planes should be distinguishable at runtime #4504.
- Related to [WIP] multi profile #4532
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
fdb3673
to
1fc9686
Compare
336b9e6
to
4c3b10e
Compare
dce27bb
to
1cc440c
Compare
3109b41
to
fbac0a6
Compare
e27358a
to
b393a83
Compare
b393a83
to
7fe8e71
Compare
Co-authored-by: Kurt Hutten <[email protected]>
This wasn't actually correct. Snapshots all rendered backwards. This reverts commit 21e8a20.
7ea6e7f
to
da5e597
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4594 +/- ##
==========================================
- Coverage 85.99% 85.92% -0.07%
==========================================
Files 82 82
Lines 30123 30131 +8
==========================================
- Hits 25903 25890 -13
- Misses 4220 4241 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
I rebase my branch on this and multi-profile works just fine on default/`startSketchOn('XY') planes.