COMP: removed dead code found by cppcheck

Added comments to some code it identified as dead but is in fact there to cause compile errors should mistakes be made elsewhere.
Kitware · Jan 7, 2025 · b7c6cb4 · b7c6cb4
1 parent 668b781
commit b7c6cb4
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/Modules/Core/Common/include/itkConceptChecking.h b/Modules/Core/Common/include/itkConceptChecking.h
@@ -702,13 +702,15 @@ struct HasNumericTraits
     void
     constraints()
     {
+      // This is here to cause compile-time failures, if a provided custom type is missing some methods.
       Detail::UniqueType<typename NumericTraits<T>::ValueType>();
       Detail::UniqueType<typename NumericTraits<T>::PrintType>();
       Detail::UniqueType<typename NumericTraits<T>::AbsType>();
       Detail::UniqueType<typename NumericTraits<T>::AccumulateType>();
       Detail::UniqueType<typename NumericTraits<T>::RealType>();
       Detail::UniqueType<typename NumericTraits<T>::ScalarRealType>();
       Detail::UniqueType<typename NumericTraits<T>::FloatType>();
+
       T a{};
 
       // Test these methods that take an instance of T to

diff --git a/Modules/Core/ImageFunction/include/itkLinearInterpolateImageFunction.hxx b/Modules/Core/ImageFunction/include/itkLinearInterpolateImageFunction.hxx
@@ -51,8 +51,6 @@ LinearInterpolateImageFunction<TInputImage, TCoordinate>::EvaluateUnoptimized(co
 
   // When RealType is VariableLengthVector, 'value' will be resized properly
   // below when it's assigned again.
-  Concept::Detail::UniqueType<typename NumericTraits<RealType>::ScalarRealType>();
-
   RealType value;
   // Initialize variable "value" with overloaded function so that
   // in the case of variable length vectors the "value" is initialized

diff --git a/Modules/Core/Mesh/test/itkParametricSpaceToImageSpaceMeshFilterTest.cxx b/Modules/Core/Mesh/test/itkParametricSpaceToImageSpaceMeshFilterTest.cxx
@@ -29,7 +29,6 @@ struct helper
 template <unsigned int VDimension>
 struct helper<itk::Index<VDimension>>
 {
-  static constexpr unsigned int Dimension = VDimension;
   using PositionType = itk::Index<VDimension>;
 
   template <class TImage, class TIterator>
@@ -43,7 +42,6 @@ struct helper<itk::Index<VDimension>>
 template <typename TCoord, unsigned int VDimension>
 struct helper<itk::Point<TCoord, VDimension>>
 {
-  static constexpr unsigned int Dimension = VDimension;
   using PositionType = itk::Point<TCoord, VDimension>;
 
   template <class TImage, class TIterator>

diff --git a/Modules/Filtering/ImageGrid/test/itkPasteImageFilterGTest.cxx b/Modules/Filtering/ImageGrid/test/itkPasteImageFilterGTest.cxx
@@ -55,8 +55,6 @@ class PasteFixture : public ::testing::Test
   template <typename TInputImage, typename TSourceImage = TInputImage>
   struct FixtureUtilities
   {
-    static const unsigned int Dimension = TInputImage::ImageDimension;
-
     using PixelType = typename TInputImage::PixelType;
     using OutputPixelType = PixelType;
     using InputImageType = TInputImage;