Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EntityGroupOp in discrete session to also handle domain set #149

Merged
merged 5 commits into from
Apr 20, 2015

Conversation

yumin
Copy link
Contributor

@yumin yumin commented Apr 20, 2015

In ModelBuilder-v3, there is a vtkModelMaterial class and its operator class,
vtkMaterialOperator. Essentially this is a partitioned group, meaning entities
can only belong to one group (in V3, the group is called Domain set, which is
normally associated with material type of attributes). In this commit, we brought
back the vtkMaterialOperator, so that users can create group of volumes (3d) or group
of faces (2d), then associate (material) attribute to them. However, ideally we
should have a univeral group op across all sessions to cluster entities, and then
these groups can be used for attribute associations.

yumin added 5 commits April 17, 2015 10:33
In ModelBuilder-v3, there is a vtkModelMaterial class and its operator class,
vtkMaterialOperator. Essentially this is a partitioned group, meaning entities
can only belong to one group (in V3, the group is called Domain set, which is
normally associated with material type of attributes). In this commit, we brought
back the vtkMaterialOperator, so that users can create group of volumes (3d) or group
of faces (2d), then associate (material) attribute to them. However, ideally we
should have a univeral group op across all sessions to cluster entities, and then
these groups can be used for attribute associations.
yumin added a commit that referenced this pull request Apr 20, 2015
Refactor EntityGroupOp in discrete session to also handle domain set
@yumin yumin merged commit ab56771 into Kitware:master Apr 20, 2015
@vibraphone
Copy link
Member

There are bits set aside in smtk/model/EntityTypeBits.h to mark groups as partitions or covers but there are no tests to enforce these rules — in part because there are no operators to construct the initial set of groups that form the partition or cover or manipulate the groups after their creation. Note that using groups this way requires 2 levels of groups: a toplevel group with the PARTITION or COVER bit set and child groups that collectively define the membership.

The 2-level groups are required so that partitions/covers do not have to encompass all entities in a model manager or session. Instead, operators should just verify that the membership of the toplevel group before and after a group operation is unchanged.

@yumin
Copy link
Contributor Author

yumin commented Apr 21, 2015

@vibraphone I file a new issue #151 with your comments added there

@yumin yumin deleted the discrete_group_op branch April 21, 2015 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants