fix(io): terminate web workers for vtk async read/write

Kitware · Dec 29, 2023 · 30c7109 · 30c7109
1 parent cb5791e
commit 30c7109
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/io/readWriteImage.ts b/src/io/readWriteImage.ts
@@ -11,7 +11,8 @@ export const readImage = async (file: File) => {
   if (file.name.endsWith('.vti'))
     return (await vtiReader(file)) as vtkImageData;
 
-  const { image } = await readImageItk(null, file);
+  const { image, webWorker } = await readImageItk(null, file);
+  webWorker.terminate();
   return vtkITKHelper.convertItkToVtkImage(image);
 };
 

diff --git a/src/io/vtk/async.ts b/src/io/vtk/async.ts
@@ -18,15 +18,18 @@ interface FailResult {
 type ReadResult = SuccessReadResult | FailResult;
 
 export const runAsyncVTKReader = (readerName: string) => async (file: File) => {
-  const worker = new PromiseWorker(
-    new Worker(new URL('./async.reader.worker.ts', import.meta.url), {
+  const asyncWorker = new Worker(
+    new URL('./async.reader.worker.ts', import.meta.url),
+    {
       type: 'module',
-    })
+    }
   );
+  const worker = new PromiseWorker(asyncWorker);
   const data = (await worker.postMessage({
     file,
     readerName,
   })) as ReadResult;
+  asyncWorker.terminate();
   if (data.status === 'success') {
     return vtk(data.obj) as vtkObject;
   }
@@ -41,15 +44,18 @@ type WriteResult = SuccessWriteResult | FailResult;
 
 export const runAsyncVTKWriter =
   (writerName: string) => async (dataSet: vtkDataSet) => {
-    const worker = new PromiseWorker(
-      new Worker(new URL('./async.writer.worker.ts', import.meta.url), {
+    const asyncWorker = new Worker(
+      new URL('./async.writer.worker.ts', import.meta.url),
+      {
         type: 'module',
-      })
+      }
     );
+    const worker = new PromiseWorker(asyncWorker);
     const result = (await worker.postMessage({
       obj: dataSet.getState(),
       writerName,
     })) as WriteResult;
+    asyncWorker.terminate();
     if (result.status === 'success') {
       return result.data;
     }