Skip to content

Commit

Permalink
Merge pull request #511 from Kitware/default-standard-rendering
Browse files Browse the repository at this point in the history
feat(cvr): default to standard rendering
  • Loading branch information
floryst authored Nov 20, 2023
2 parents b69dd99 + 049ba49 commit ee36234
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 18 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
fetch-depth: 0
- name: Install dependencies
run: npm ci
env:
DETECT_CHROMEDRIVER_VERSION: true
- name: Install xvfb (linux)
if: matrix.os == 'ubuntu-20.04'
run: sudo apt-get install xvfb
Expand Down
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"chai-almost": "^1.0.1",
"chai-as-promised": "7.1.1",
"chai-subset": "^1.6.0",
"chromedriver": "^117.0.0",
"chromedriver": "^119.0.0",
"concurrently": "^8.2.2",
"cross-env": "^7.0.3",
"eslint": "^7.32.0",
Expand Down Expand Up @@ -126,4 +126,4 @@
"eslint"
]
}
}
}
2 changes: 1 addition & 1 deletion src/store/view-configs/volume-coloring.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const defaultVolumeColorConfig = (): VolumeColorConfig => ({
enabled: true,
lightFollowsCamera: true,
volumeQuality: 2,
useVolumetricScatteringBlending: true,
useVolumetricScatteringBlending: false,
volumetricScatteringBlending: 0.5,
useLocalAmbientOcclusion: true,
laoKernelRadius: 5,
Expand Down

0 comments on commit ee36234

Please sign in to comment.