-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation Tool Hover #404
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I'll try getting distances to each line to sort among tools the pointer is inside. Getting fancy. First pass I had earler was to show popover when hovering over handles or lines, same target area as context menu. Was probably going to do that approach that for Ruler, as bounding box could be a bit much for the diagonal ruler? Maybe we go with that hardware picker approach for all tools for now and refine our "2D picking" approach later?
Argeed. Can't escape that needy popover. 🤣 Did not do the offset from bounding box cuz if camera is zoomed in and annotation bounds is out of frame, won't see popover. Was common situation in catheter based modality project i worked on. How about a debouce on mouse movement before showing popover? |
Thanks for checking on this early. Good points! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! I presume you are going to update this for the rectangle and ruler?
One other thing: we will do some user testing to see how people feel about the delay in popup. I don't have a better idea at the moment. |
Remove bounds changes to Polygon state. Remove array for watch.
Added hover support to Ruler and Rectangle. Yes, hover feel is not great. But do need something to get "Label" of annnotation ASAP. Alternatives:
|
I like the right click context menu approach the most, especially since I have some half-written code snippet somewhere that allows you to switch the label of an annotation via the context menu. The select tool I plan on working on can be the inspect tool you're referring to. In select mode, hovering can show the label (debounced or not). |
Overall, LGTM. The icon spacing for the context menu seems kind of big, which makes entries without icons (e.g. the polygon tool's "Delete Point") look out of place. |
Added blank icon to fix "Delete Point". Added a "Select" tool that enables the hover popup. Included |
LGTM! |
Hover popup appears 250ms after cursor rests on invisible vtkWidgetRepresentation.
Current look:
Old look: