Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop whatwg-url #411

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Drop whatwg-url #411

merged 1 commit into from
Nov 13, 2023

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Sep 7, 2023

whatwg-url parses correctly, but is quite a big dependency. This adds a parseUrl() that only handles Chrome+Firefox quirks regarding parsing of urls using non-special schemes.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 6b5fca8
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6552ac7d1774770008d42c5e
😎 Deploy Preview https://deploy-preview-411--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@floryst floryst force-pushed the drop-whatwg-url branch 2 times, most recently from e610067 to 61512fc Compare September 12, 2023 21:20
@floryst floryst force-pushed the drop-whatwg-url branch 2 times, most recently from 47a2d7e to 90db59c Compare October 10, 2023 16:53
@floryst floryst force-pushed the drop-whatwg-url branch 3 times, most recently from 276168b to 3ea387a Compare November 13, 2023 22:57
whatwg-url parses correctly, but is quite a big dependency. parseUrl()
only handles Chrome+Firefox quirks regarding parsing of urls using
non-special schemes.
@floryst floryst added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 58eb163 Nov 13, 2023
7 checks passed
@floryst floryst deleted the drop-whatwg-url branch March 21, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant