Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(onVTKEvent): easier event interface #413

Merged
merged 1 commit into from
Sep 12, 2023
Merged

refactor(onVTKEvent): easier event interface #413

merged 1 commit into from
Sep 12, 2023

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Sep 8, 2023

The onVTKEvent interface is more straightforward and familiar (e.g. the addEventListener interface) than the useVTKCallback interface.

@floryst floryst requested a review from PaulHax September 8, 2023 18:21
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 232557d
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/65007f59ddf90b0008e7bd5d
😎 Deploy Preview https://deploy-preview-413--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objectivly better.

@floryst floryst merged commit eaa39bd into main Sep 12, 2023
7 checks passed
@floryst floryst deleted the on-vtk-event branch September 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants