Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CurrentImageProvider): move higher in component tree for MeasurementsToolList #417

Closed
wants to merge 1 commit into from
Closed

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Sep 12, 2023

No description provided.

@PaulHax PaulHax requested a review from floryst September 12, 2023 18:48
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7062759
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6500b7bf34bd7600083c4cbe
😎 Deploy Preview https://deploy-preview-417--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title fix(CurrentImageProvider): move higher component tree for Measurement… fix(CurrentImageProvider): move higher in component tree for MeasurementsToolList Sep 12, 2023
@PaulHax PaulHax marked this pull request as draft September 12, 2023 19:07
@PaulHax PaulHax marked this pull request as ready for review September 12, 2023 19:11
@floryst
Copy link
Collaborator

floryst commented Sep 12, 2023

I'm good to revert my changes while we work out the details for what it means across the entire app. Plus, having a different dataset per view makes other parts of the app a bit confusing, since we don't have a defined behavior for such scenario.

@floryst
Copy link
Collaborator

floryst commented Sep 12, 2023

See: #418

@PaulHax
Copy link
Collaborator Author

PaulHax commented Sep 12, 2023

superseded by #418

@PaulHax PaulHax closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants