feat(WebXR): Add initial support for WebXR viewing with VTK.js #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tbirdso
force-pushed
the
xr-looking-glass
branch
from
fee51f7 to
3414782
Compare
|
Note that we have observed an issue on Firefox where VolView appears to initially grab the orientation box render window rather than the volume rendering render window for its view proxy. Suggest testing on Chrome or Edge browsers instead. |
Adds initial support for viewing VolView scene in WebXR on the local device. Note that performance may vary widely across devices.
tbirdso
force-pushed
the
xr-looking-glass
branch
from
6ec6c5a to
c4eec76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for viewing VolView scene in WebXR on the local device. Note that performance may vary widely across devices.
Depends on updates to VTK.js WebXR rendering structures in Kitware/vtk-js#2924 .
Opening as a draft PR for discussion and feedback. Note that rendering performance may vary highly across platforms. We may want to explore optimization improvements for VTK.js WebXR rendering and/or disable some XR platform options in VolView for the initial merge.
Many thanks to @PaulHax and @floryst for helping me with VolView development 🚀
Suggested remaining TODOs: