Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VtkTwoView): layer opacity has uniform 1 opacity transfer function #449

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix(VtkTwoView): layer opacity has uniform 1 opacity transfer function #449

merged 3 commits into from
Oct 25, 2023

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 8, 2023

Removes voxel intensity based opacity transfer for layer slices. All layer voxels have opacity transfer function Y value of 1. Layer opacity controled by slice mesh opacity.

Good CT-PT dataset for testing https://demo.orthanc-server.com/app/explorer.html#study?uuid=6b9e19d9-62094390-5f9ddb01-4a191ae7-9766b715

Closes #355

@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3257595
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/653919cc133c1800082cd26e
😎 Deploy Preview https://deploy-preview-449--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title fix(VtkTwoView): layer opacity slider give full opacity fix(VtkTwoView): layer opacity slider changes opacity from 0 to 1 Oct 8, 2023
@floryst
Copy link
Collaborator

floryst commented Oct 9, 2023

LGTM

@salimkanoun
Copy link

Hi there, the fusion is better but i think there still a problem, from 0.8 to 1 I don't see real change in opacity.

I see the opacity seems to be defined using gaussians, points or node while I think for PET/CT is should be a simple constant for all pixel in the image which balance with the CT opacity ( changing 0 to 1 with always Opacity CT + Opacity PT = 1)

For a layer are all voxel opacity a constant in the current code ?

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 10, 2023

@salimkanoun Your right, .8 to 1 does nothing. This PR was trying to preserve CT context with some intensity to opacity mapping. Uniform opacity across image would be too easy =)

But you've finaly gotten through to me. I'll make the PET/layer's opacity uniform across the image, and the slider will change the opacity of the layer uniformly.

@salimkanoun
Copy link

Sounds good, will try the new implementation, thanks !

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 11, 2023

I pushed up the simpler layer blending approach.

@salimkanoun
Copy link

Seems to me much better ! Thanks !

@PaulHax PaulHax changed the title fix(VtkTwoView): layer opacity slider changes opacity from 0 to 1 fix(VtkTwoView): layer opacity has uniform 1 opacity transfer fucntion Oct 12, 2023
@PaulHax PaulHax changed the title fix(VtkTwoView): layer opacity has uniform 1 opacity transfer fucntion fix(VtkTwoView): layer opacity has uniform 1 opacity transfer function Oct 12, 2023
@floryst
Copy link
Collaborator

floryst commented Oct 13, 2023

LGTM!

@floryst
Copy link
Collaborator

floryst commented Oct 23, 2023

@PaulHax we can merge this once it's rebased.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 25, 2023

Rebased!

@PaulHax PaulHax merged commit e664a17 into Kitware:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opacity not linear / underestimated ?
3 participants