fix(ruler): avoid error when manipulator returns no worldCoords #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This looks to be an oversight on how we use worldCoords after the vtk.js@v28 upgrade.
It sounds like all of the widgets need to be checked for their usage of |
floryst
reviewed
Oct 27, 2023
src/vtk/PaintWidget/behavior.ts
Outdated
|
|
||
| if (!worldCoords) { | ||
| console.warn('Event cannot be converted to world coordinates'); |
Comment on lines
+51
to
+52
| if (!worldCoords) | ||
| console.warn('Event cannot be converted to world coordinates'); |
There was a problem hiding this comment.
I think our current manipulators shouldn't trigger this unless there's an error case, so this is a good add. If we start getting them legitimately, then we can remove it.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that Paint is hurting too...