Miscellaneous fixes #502
Merged
Miscellaneous fixes #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
floryst
commented
Nov 10, 2023
floryst
commented
- Allow selection of text in the message list
- completely disconnect the ResizeObserver on unmount
- Log out global errors and use a fallback message for error reporting
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
approved these changes
Nov 10, 2023
| @@ -5,7 +5,11 @@ export function useGlobalErrorHook() { | |||
| const messageStore = useMessageStore(); | |||
|
|
|||
| const onError = (event: ErrorEvent) => { | |||
| messageStore.addError('Application error (click for details)', event.error); | |||
| console.error(event); | |||
There was a problem hiding this comment.
Good! Thinking we should send more errors to Sentry via:
Sentry.captureException https://docs.sentry.io/platforms/javascript/usage/
or
Sentry.init({
dsn: 'https://your-sentry-server-dsn',
integrations: [
new CaptureConsole({
levels: ['error']
})
],
...
There was a problem hiding this comment.
I like this idea! I'll cover this in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.