Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): show toggle sidebar button by default #520

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jadh4v
Copy link
Collaborator

@jadh4v jadh4v commented Nov 27, 2023

Addresses: #519

Show the "toggle sidebar" button by default on all platforms. Earlier it was only enabled for mobile devices. Showing the button on all platforms will enable the user to explicitly show/hide the sidebar as desired.

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ff6b86a
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/65650c96446cb40008efe749
😎 Deploy Preview https://deploy-preview-520--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jadh4v
Copy link
Collaborator Author

jadh4v commented Nov 27, 2023

@floryst

@floryst
Copy link
Collaborator

floryst commented Nov 27, 2023

Looks like you need to run npm run prettify to address the linter error.

@PaulHax PaulHax linked an issue Nov 27, 2023 that may be closed by this pull request
@jadh4v jadh4v force-pushed the enh-collapsible-sidebar branch from ec40681 to ff6b86a Compare November 27, 2023 21:39
@jadh4v jadh4v requested a review from floryst November 27, 2023 21:43
@floryst floryst added this pull request to the merge queue Nov 30, 2023
Merged via the queue into Kitware:main with commit 80f534c Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side panel should be collapsible and/or resizeable
2 participants