Segment group file format selection for serialization #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
force-pushed
the
export-segment-group
branch
from
6286cb4 to
97257f2
Compare
PaulHax
changed the title
PaulHax
force-pushed
the
export-segment-group
branch
from
97257f2 to
e2a0984
Compare
PaulHax
force-pushed
the
export-segment-group
branch
from
e2a0984 to
df5e8f1
Compare
jadh4v
reviewed
Dec 6, 2023
PaulHax
force-pushed
the
export-segment-group
branch
from
4345276 to
a2634a7
Compare
|
This is good to go by me. Followup PR for GUI export button. |
PaulHax
commented
Dec 8, 2023
PaulHax
force-pushed
the
export-segment-group
branch
from
0df0301 to
94693c9
Compare
Closed
jadh4v
approved these changes
Dec 21, 2023
| import { FileReaderMap } from '.'; | ||
|
|
||
| import { readFileAsArrayBuffer } from './io'; | ||
| import { stlReader, vtiReader, vtpReader } from './vtk/async'; |
There was a problem hiding this comment.
Looks like itk-wasm/mesh-io also has a similar generic reader for polydata? Maybe in the future we could get rid of these special readers as well.
There was a problem hiding this comment.
Yes, cool. VolView's mesh support is just vestigial at the moment.
| @@ -203,6 +203,7 @@ export const useDicomWebStore = defineStore('dicom-web', () => { | |||
| state: 'Done', | |||
| }; | |||
| } catch (error) { | |||
| console.error(error); | |||
There was a problem hiding this comment.
Do you want to keep this, or was just added during debugging?
There was a problem hiding this comment.
Good check, did want to keep actualy.
Add segmentGroupSaveFormat section.
PaulHax
force-pushed
the
export-segment-group
branch
from
55cb8a3 to
67d2631
Compare
floryst
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolView will save "segment group" images into a file format configurable by a config.JSON file.
deserializewill read whatever format it finds in the .zip file.This is the config json to change the saved format
To test: Can drag and drop this config file on VolView before saving.
config-save-format.json
Possible formats here:
https://github.com/InsightSoftwareConsortium/itk-wasm/blob/main/packages/image-io/typescript/src/extension-to-image-io.ts
TODO
- [ ] Add GUI to set format, maybeFollow up PR to add GUI.