-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert a loaded image to segment group #528
Convert a loaded image to segment group #528
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Good stuff. What do you think about having an "Add segmentation group from loaded image" button under the Annotation Tab->Segment Groups? After removing the converted image from the Data Browser how can I:
|
Current way to undo is to simply delete the segment group and re-open the file as image again. Do you think it is a frequent use-case to go back-and-forth between image and labelmap representations? Yes, we can also add the option "Add segmentation group from loaded image" in the annotations tab. I will add that. |
I don't think there is much of a reason to have a dedicated undo functionality yet. Let's get one direction working and then we can add the other direction when there is sufficient interest/reason to do so. |
193206a
to
f79e361
Compare
f79e361
to
b2850fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DICOM Seg images make sense to convert to segment groups yeah? I guess we should just recongize that DICOM Seg objects have a base DICOM image and we just apply them to that image automatily? Is it common for this metadata matchup to fail and it would be useful to allow user to convert manually?
I think we can address this when working on explicitly handling SEG DICOM objects (basically when implementing the automatic part). |
06edd6a
to
857585c
Compare
857585c
to
37e7622
Compare
Works good. Good to merge? |
Yes, please merge. No further changes in queue. |
Convert a loaded image into a labelmap / segment group.
Choosing this option will remove the image from the list of loaded datasets, and create a new segment group under annotations tab using the image as a segmentation/labelmap.
This operation can fail if the segmentation image does not match the bounds of the selected primary image (base image on which the segmentation is to be applied).
WIP, additional points that need fixing:
These changes should also support conversion of a dicom segmentation to labelmap, but testing this will require a fix in itk-wasm for this issue: readImageDicomFileSeries doesn't read segmentation dicom correctly InsightSoftwareConsortium/ITK-Wasm#991Snapshots