Label name uniqueness tweeks #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
force-pushed
the
labels-save-id
branch
from
a019c4f to
59c69df
Compare
|
I think it would be a good idea to enforce name uniqueness and not let the user create labels with duplicate names. Have we encountered a use-case for different labels with the same name? |
|
No known use case for duplicate names. I'll disable "Done" if name is used. |
PaulHax
force-pushed
the
labels-save-id
branch
from
59c69df to
d6ac93c
Compare
PaulHax
force-pushed
the
labels-save-id
branch
from
d6ac93c to
3e49354
Compare
|
Disabled Done button for segment and label editors if name already exists. |
floryst
approved these changes
Feb 23, 2024
|
Looks like there are issues with code formatting. |
* remove clear default labels flag from mergeLabels and make explicit function. * set max width to LabelControls label editor
Still allows duplicate names if user presses "Done". New labels are created with unique names suffixed with a number. New labels loop through the confgi.ts:TOOL_COLORS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warns if user is editing label name and it maches existing label. "Done" is disabled if name already exists.
Also
Closes #477