Refactoring the App component for customization #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requireProxyManager replaces withProxyManager, explicitly throwing an error if the proxy manager is unavailable.
- Improve readability for renderLater - Drop the delayed render parameter for publicAPI.render
A new load-data store is made available to make the loading state available outside the App component.
Splits out the WelcomePage to add more override points.
Split up the app component to facilitate more override points. ToolStrip has been renamed to ControlsStrip to avoid name conflicts with the tools.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the commits for a full understanding of the changes. In short, the App component has been split up to facilitate more integration points. Furthermore, some new stores have been created to properly share data across components.