-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overriding the current image #548
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d16292b
to
edd9ac7
Compare
Decouples the current image from the current selection.
edd9ac7
to
c57abd7
Compare
Hello, Thank you. |
You can use the CurrentImageProvider as outlined below. Note that this is only most relevant for making custom changes to the app, and it does make it possible for us to support viewing multiple datasets at the same time in the future.
|
Actually, that's what I'm trying to do (view multiple dataset). Given that the current-image-provider already exists, what is missing to be able to view multiple datasets ? I actually tried what you mentioned, but I don't see how to change image for this vtk-slice-view then. |
You could write some code (pinia store?) where given a "view id" it gives you a |
I'm gonna look at this soon, because it's something I would need :) |
Hello, I'm working on specifying an image for each view, so we could display multiple images at once (like to compare images, etc...). |
I want it all. =) Methinks every user action does need some visual space holding button/select-dropdown/whatever so the user knows the action is possible. Buzzword -> discoverablity. Then we add acclerators like drag+drop and keyboard shortcuts. |
@floryst I saw in an other post that you want to unify image list (DICOM + other images). I think that would be useful here, so we can select from all images which image to display on a specific view. Do you know if this is something that would be available soon ? |
Ok, I was trying to implement this 'multiple images' feature, but I ran into an architecture issue. If each view can have a different image, then we need to keep a mapping of which view display which images. I was working on that, but I realized this is somehow incompatible with the current architecture, where only 1 image is active at a time. So, now I'm not sure what would return My idea would be to change Is it a path you are willing to go ? Otherwise, can you think about an alternative way ? Thank you. |
This is indeed a harder problem to solve, since it affects UX and internals. I would like to go down that route, but I haven't had the time to do so. Here are some of my thoughts.
I almost expect most of the effort to be on making the UI and UX operate smoothly for views with different datasets. I suppose my second point above would be the easiest approach to doing so, but that's from a high-level perspective. |
Unfortunately, I don't have a deep enough understanding of everything in VolView to figure this out (not on my own at least). How should we proceed ? |
The
CurrentImageProvider
component can now override the image returned fromuseCurrentImage()
for a given subtree. The fallback behavior is to use the current global selected image.This revives #410 with the fallback behavior.