Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useCurrentImage): return defaults/null #551

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(useCurrentImage): return defaults/null #551

merged 1 commit into from
Feb 13, 2024

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Feb 12, 2024

  • getImageMetadata: return defaults if no image ID or if imageID is nonexistent, since the method signature doesn't return null.
  • Make sure getImageData's return signature only returns null.

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2024 •
edited
Loading

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 50ad98d
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/65ca916dff0cd900083a82bf
😎 Deploy Preview https://deploy-preview-551--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@floryst floryst added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 9c5f2b4 Feb 13, 2024
7 checks passed
@floryst floryst deleted the fix-usecurrentimage branch March 21, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@floryst