Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freehand point dropping for Polygon Tool #589

Merged
merged 5 commits into from
May 10, 2024
Merged

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented May 1, 2024

Hold left mouse button down to keep dropping points. Optimizes point count after polygon is "placed."

Copy link

netlify bot commented May 1, 2024

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7dc8823
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/66341937512d1d0008f31fa3
😎 Deploy Preview https://deploy-preview-589--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@floryst
Copy link
Collaborator

floryst commented May 2, 2024

Freehand results in a lot of closely-spaced point handle circles, even with polyline decimation. One possible solution to this issue is to instead only show the closest handle circle to the mouse.

@PaulHax
Copy link
Collaborator Author

PaulHax commented May 2, 2024

Freehand results in a lot of closely-spaced point handle circles, even with polyline decimation. One possible solution to this issue is to instead only show the closest handle circle to the mouse.

Agreed. Changed to showing handles on hover.

@floryst
Copy link
Collaborator

floryst commented May 10, 2024

LGTM

@floryst floryst added this pull request to the merge queue May 10, 2024
Merged via the queue into Kitware:main with commit f25fb04 May 10, 2024
7 checks passed
1isten added a commit to 1isten/VolView that referenced this pull request May 12, 2024
Merge pull request Kitware#589 from Kitware/VolView:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants